Comments on: Coding Dojo #17: Refactoring Cruise Control .NET http://www.markhneedham.com/blog/2009/06/12/coding-dojo-17-refactoring-cruise-control-net/ Thoughts on Software Development Sat, 11 Feb 2012 23:17:00 +0000 hourly 1 http://wordpress.org/?v=3.3.1 By: introducing a ChangeSet class to CruiseControl.net: shifting to supertypes – in two places at once http://www.markhneedham.com/blog/2009/06/12/coding-dojo-17-refactoring-cruise-control-net/comment-page-1/#comment-19810 introducing a ChangeSet class to CruiseControl.net: shifting to supertypes – in two places at once Wed, 08 Jul 2009 12:42:14 +0000 http://www.markhneedham.com/blog/?p=1321#comment-19810 [...] the base of the hierarchy provides the most flexibility for implementing another class. I know from previous experimentation that we can use IEnumerable<Modification> for everything except the tests. Linq can cover the [...] [...] the base of the hierarchy provides the most flexibility for implementing another class. I know from previous experimentation that we can use IEnumerable<Modification> for everything except the tests. Linq can cover the [...]

]]> By: introducing a ChangeSet class to CruiseControl.net: why? « in two places at once http://www.markhneedham.com/blog/2009/06/12/coding-dojo-17-refactoring-cruise-control-net/comment-page-1/#comment-19760 introducing a ChangeSet class to CruiseControl.net: why? « in two places at once Tue, 07 Jul 2009 09:21:48 +0000 http://www.markhneedham.com/blog/?p=1321#comment-19760 [...] make a few more posts about it. My colleague Mark Needham already posted about a dojo where we did some experimentation around [...] [...] make a few more posts about it. My colleague Mark Needham already posted about a dojo where we did some experimentation around [...]

]]> By: Mark Needham http://www.markhneedham.com/blog/2009/06/12/coding-dojo-17-refactoring-cruise-control-net/comment-page-1/#comment-18684 Mark Needham Mon, 15 Jun 2009 12:02:32 +0000 http://www.markhneedham.com/blog/?p=1321#comment-18684 Hmmm that makes it a bigger refactoring/code change than we anticipated although I imagine our approach wouldn't be that different than what we did in this dojo. Just there's more steps to it now! Hmmm that makes it a bigger refactoring/code change than we anticipated although I imagine our approach wouldn’t be that different than what we did in this dojo. Just there’s more steps to it now!

]]> By: DCam http://www.markhneedham.com/blog/2009/06/12/coding-dojo-17-refactoring-cruise-control-net/comment-page-1/#comment-18629 DCam Sun, 14 Jun 2009 04:42:58 +0000 http://www.markhneedham.com/blog/?p=1321#comment-18629 Now with more generics: It occured to me after, that a single call to GetModfications could result in multiple ChangeSets. So a ChangeSet that implements ICollection<Modification> is not enough. The return value of GetModifications should implement both IEnumerable<Modification> and IEnumerable<ChangeSet>. Now with more generics:

It occured to me after, that a single call to GetModfications could result in multiple ChangeSets. So a ChangeSet that implements ICollection<Modification> is not enough. The return value of GetModifications should implement both IEnumerable<Modification> and IEnumerable<ChangeSet>.

]]> By: DCam http://www.markhneedham.com/blog/2009/06/12/coding-dojo-17-refactoring-cruise-control-net/comment-page-1/#comment-18628 DCam Sun, 14 Jun 2009 04:41:03 +0000 http://www.markhneedham.com/blog/?p=1321#comment-18628 It occured to me after, that a single call to GetModfications could result in multiple ChangeSets. So a ChangeSet that implements ICollection is not enough. A ChangeSetCollection that implements both IEnumerable and IEnumerable is needed for the return value of GetModifications. It occured to me after, that a single call to GetModfications could result in multiple ChangeSets. So a ChangeSet that implements ICollection is not enough. A ChangeSetCollection that implements both IEnumerable and IEnumerable is needed for the return value of GetModifications.

]]>